Skip to content

rename lint_dir() test file for consistency #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

rename lint_dir() test file for consistency #2142

merged 1 commit into from
Sep 12, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Related: #2135

@AshesITR
Copy link
Collaborator

Pull lint_dir() into R/lint_dir.R?

@MichaelChirico
Copy link
Collaborator Author

Pull lint_dir() into R/lint_dir.R?

That'll probably happen... my thinking is we should nail down exactly how #2135 will happen before doing that. This change can happen regardless since (1) git mv shows cleanly in the git history (whereas moving a code chunk is a bit harder to trace) (2) it's consistent with how lint_package() is tested in test-lint_package.R (https://github.com/r-lib/lintr/blob/a59c6c06229c6e9c71d910fe31d379a554255bea/tests/testthat/test-lint_package.R).

@AshesITR AshesITR merged commit 203be65 into main Sep 12, 2023
@AshesITR AshesITR deleted the lint-test-rename branch September 12, 2023 04:32
@MichaelChirico MichaelChirico mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichaelChirico @AshesITR