Skip to content

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1689

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #2091 (76548c4) into main (6713862) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 76548c4 differs from pull request most recent head 7f68e38. Consider uploading reports for the commit 7f68e38 to get more accurate results

@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files         117      117           
  Lines        5142     5144    +2     
=======================================
+ Hits         5124     5126    +2     
  Misses         18       18           
Files Changed Coverage Δ
R/fixed_regex_linter.R 100.00% <100.00%> (ø)
R/shared_constants.R 93.54% <100.00%> (+0.44%) ⬆️

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some wording

@MichaelChirico MichaelChirico merged commit ec10c38 into main Aug 21, 2023
@MichaelChirico MichaelChirico deleted the fixed-unescaped branch August 21, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixed_regex_linter could optionally skip special-free strings
3 participants