Some refactoring to clarify logic in complicated linters #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stage file fix indentation cyclocomp for namespace_linter cyclocomp indentation_linter superficial changes to object_usage_linter new lints typo some progress using all.vars fix regressions more easy wins a few more improvements restore more complicated changes (with cyclocomp fixes retained) smaller diff review feedback
Codecov Report
@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 117 117
Lines 5058 5038 -20
==========================================
- Hits 5040 5020 -20
Misses 18 18
|
|
Maybe makes sense to further split off the |
AshesITR
reviewed
Aug 10, 2023
|
I wouldn't mind either way. |
AshesITR
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2069
Follow-up #2063, split off the refactoring pieces from the pure copy-paste pieces.