global variables not found?

[randy3k]

Script global variables should be detected, but they are not.

SublimeLinter: r output:
/var/folders/w9/7w10svxj5093z4831n7m27w00000gp/T/SublimeLinter3-randy/untitled.lintr:8:5: warning: no visible global function definition for ‘foo’, Did you mean 'for'?
    foo(y) + increment
    ^~~
/var/folders/w9/7w10svxj5093z4831n7m27w00000gp/T/SublimeLinter3-randy/untitled.lintr:8:14: warning: no visible binding for global variable ‘increment’
    foo(y) + increment
             ^~~~~~~~~ 

[jimhester]

This is an unfortunate side effect from switching to parsing each top-level expression separately (so that each expression can be cached separately) rather than parsing the whole file at once.

If you are developing a package lintr will include of the symbols in the package namespace as globals (you just need to install some version of the in-development package).

This should get fixed though, thanks for opening the issue.

[randy3k]

Hi Jim,

Thanks for the quick response. I forgot to thank you for this amazing package. I have been looking for a comprehensive R linting package for a while until I discovered this.

I work with R script files most of the time. It would be great if lintr can handle script global variables correctly.

One more thing: I tried to turn off the cache function, it reports the same lint results.

[jimhester]

Need to tweak logic at R/object_usage_linter.R#L8-L19 to evaluated the current file and include the top level names.

[KDr2]

Is someone working on this? or I can disable some linter to avoid this?
Thanks

[jimhester]

You can disable the object_usage_linter to avoid it.

[galadude]

I'm having this problem aswell. Can you tell me how to disable object_usage_linter?

[user01]

@galadude You can set the used linters when calling lint. For example:

lintr::lint_package(linters=lintr::default_linters[-14])

I checked names(lintr::default_linters), "found object_usage_linter" index, and removed it for the lint.

[fangly]

I am also having "no visible global function definition for 'bakName'" and "no visible binding for global variable for global variable 'test'" lints, though, they only happen in my "tests/testthat/helper_utils.R" file:

test <- new.env()


bakName <- function(funName, envir) {
  paste0(environmentName(envir), "_", funName, ".bak")
}

overwriteFunction <- function(oldFun, newFun, envir=baseenv()) {
  assign(bakName(oldFun, envir), get0(oldFun, envir = envir), envir = test)
  assign(oldFun, newFun, envir = envir)
}

My "R/*" files do not generate it, and neither do my "tests/testthat/test*.R" files.

[bcipolli]

Any sense of priority on this? The linter complains about functions defined within the same file, not being found; this seems pretty basic.

Disabling the linting check ... defeats the purpose of having a linter. It's a critical check for a linter to do.

It's been almost 3 years; can anything be done to bump up the priority on this? I'm not sure my R chops are up to snuff to tackle this one..

[leonelgalan]

I'm very new to R, so I'm not sure if this is the same issue but doing:

library(bar)
foo <- bar()

Give me a "no visible global function for bar, did you mean 'x'?" This code works, this library, defines the function, is just a lintr issue.

Is the key still in https://github.com/jimhester/lintr/blob/master/R/object_usage_linter.R#L8-L19 like suggested by @jimhester? He said "to evaluated the current file and include the top level names.", any one has pointers of where to get started?