unreachable_code_linter carve-out for 'nolint end' should also apply to 'nocov end'

[MichaelChirico]

This is currently linted:

lintr/R/get_source_expressions.R

Line 281 in 0815b2a

# nocov end

[AshesITR]

Maybe allow comments in general?

[MichaelChirico]

I guess optionally, but they're specifically included:

lintr/R/unreachable_code_linter.R

Lines 112 to 116 in ef82966

	drop_nolint_end_comment <- function(expr) {
	is_nolint_end_comment <- xml2::xml_name(expr) == "COMMENT" &
	re_matches(xml_text(expr), settings$exclude_end)
	expr[!is_nolint_end_comment]
	}

Often come across things like

return(x)
# debugging
# print(x)

commented_code_linter() helps a little bit here but TBH that linter is far from a place where I'd apply it to my own code or to code at scale.

[AshesITR]

I see. Is there a similar way to find what # nocov end is configured to be?

[MichaelChirico]

Looks like we can simply read options():

https://github.com/r-lib/covr/blob/54de614f5c17a42bfaef2c87dbf5723ca701326a/R/exclusions.R#L55-L57

[AshesITR]

Looks like we can simply read options():

https://github.com/r-lib/covr/blob/54de614f5c17a42bfaef2c87dbf5723ca701326a/R/exclusions.R#L55-L57

Sweet, and it's a regex too.
Might extend the linter to allow for a comment regex whitelist later? We can default it to nolint end and nocov end.