-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAN check failure after adding lifecycle #39
Comments
Removing |
You can also ignore the NOTE in your CI system, CRAN will build the manual to check it in any case. |
Eh, but this resulted in a rejected CRAN submission,
|
I haven't encountered this case yet, not sure what's going on. Maybe you have to build without |
I've never used |
Maybe @gaborcsardi knows more about this sort of issues with Sexpr. |
At a minimum, the error message could be made more specific and understandable. |
@jpritikin where is your tarball? |
Sry, I mean, a full check on a CI or by CRAN. |
Can you explain more fully? The version with lifecycle never got onto CRAN (see rejection above). What do you mean by "CI"? If you mean continuous integration then I never did a
There are no further details about the context. I can run it again and post a tarball of the full check results, if that would help. Let me know what you need. Thanks. |
Failed CRAN submissions should be here: https://win-builder.r-project.org/incoming_pretest/ and there is a bunch for OpenMx, although I don't know which one failed for lifecycle. The current OpenMx repo also does not use lifecycle AFAICT. Is there a branch or ref that does? |
Oh! Look here |
Yeah, so the problem is that you |
Whoa! OpenMx uses the build directory as a temporary place to stash random build artifacts. I didn't realize that it would clash with R's package workflow. How about if I use a directory called |
I guess so. |
I'll try it. Thanks for your help! |
Thanks @gaborcsardi I would never have figured this out! |
@jpritikin I'm having a similar issue. Hoping you or another expert on the thread might be able to provide some additional insight since there isn't much addressing the issue on StackOverflow or elsewhere. Thanks so much for your time and ideas! My CRAN submission passed somehow 🤷♂️ even though all of my GitHub Action (GHA) workflows show that same message since adding the lifecycle badges to my package
Attempted fixes I've tried the following to no avail:
but the check still prints out the same message very early on in the process. I'm not sure how to silence the message or really what I could do to ensure that future CRAN submissions pass. Start of GitHub Action Log that runs R CMD check Run rcmdcheck::rcmdcheck(args = c("--as-cran"), error_on = "warning", check_dir = "check")
── R CMD build ─────────────────────────────────────────────────────────────────
* checking for file ‘.../DESCRIPTION’ ... OK
* preparing ‘salesforcer’:
* checking DESCRIPTION meta-information ... OK
* installing the package to process help pages
* creating vignettes ... OK
* checking for LF line-endings in source and make files and shell scripts
* checking for empty or unneeded directories
* building ‘salesforcer_0.2.0.tar.gz’
── R CMD check ─────────────────────────────────────────────────────────────────
* using log directory ‘/Users/runner/work/salesforcer/salesforcer/check/salesforcer.Rcheck’
* using R version 4.0.2 (2020-06-22)
* using platform: x86_64-apple-darwin17.0 (64-bit)
* using session charset: UTF-8
* using option ‘--as-cran’
* checking for file ‘salesforcer/DESCRIPTION’ ... OK
* this is package ‘salesforcer’ version ‘0.2.0.9000’
* package encoding: UTF-8
* checking CRAN incoming feasibility ... NOTE
Maintainer: ‘Steven M. Mortimer <***>’
Package has help file(s) containing install/render-stage \Sexpr{} expressions but no prebuilt PDF manual.
* checking package namespace information ... OK
* checking package dependencies ... OK
... (log continues) |
Try using inline markdown to create the badges: #' `r lifecycle::badge("deprecated")` This requires a recent roxygen. This is now the recommended way to insert a badge, though the documentation hasn't followed up yet. |
@lionel- Thanks for the quick reply! That works! It also fixes the error messages from {spelling} as noted in #19 and ropensci/spelling#42 Thanks again! |
* update README: new features, cut down on authentication * tweak REEADME * stash changes * create scaffolding for "boxr" vignette * Add caution to box_source(), make it internal so as not to publicize. * removing `box_source()` from pkgdown advertisement * finish (?) scaffolding for README, boxr vignette * bump version * version history into pkgdwn * deprecate box_dir_invite * add lifecycle badges for superseded/deprecate * add superseded section to pkgdwn * remove refs for box_previous_versions * add Finder shortcutss, fix #180 * upsdate README * small tweak * another tweak * fix typo * clean up boxr vignette, harmonize order with function reference * provide shell for design vignette * change title * pull upstream, advance version * refer to issue rather than PR * bump version * update email address * document JWT-time workaround * update URLs, feedback from check_win_devel() * amend a couple URLs missed last time * update more links * fix typo * use newer syntax for lifecycle badges: r-lib/lifecycle#39 (comment) * first swipe at design vignette * neuter vignette * throw over the wall * tweak function titles and return values * document NULL-return more consistently * canonical definitions for file_id, dir_id in box_browse() * regularize parameter-inheritance * add section on documetation normalization * add to canonical parameter-definitions * update like for Box directory reference * add libgit2-dev to package addons (gert) Co-authored-by: Nathan Day <nathancday@gmail.com>
CRAN check of OpenMx started failing with,
This problem disappeared after I revert the addition of lifecycle.
Any idea about the root cause? I'd like to use lifecycle, but I can't.
The text was updated successfully, but these errors were encountered: