-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates to the default DESCRIPTION file #428
Conversation
@@ -213,10 +213,12 @@ build_description <- function(name, extra = list()) { | |||
|
|||
defaults <- compact(list( | |||
Package = name, | |||
Title = "", | |||
Description = "", | |||
Type = "Package", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be omitted since it's the default.
Looks good. A few minor points inline. |
All good suggestions. Here's the new output:
|
Great. Could you please add a bullet point to NEWS.md briefly describing the change and thanking yourself (via your github username) |
Sure, thanks! You might consider bringing the RStudio defaults in line with the new devtools defaults. When you create a new package project in RStudio, here's what it gives you:
|
Some updates to the default DESCRIPTION file
Thanks. @jjallaire if you get a chance, it'd be great if the rstudio defaults matched this. |
I started with a clean slate on this pull request to address the issues discussed in #411. For reference, here they are again:
I made the default
DESCRIPTION
file created by devtools more similar to the defaultDESCRIPTION
file created by RStudio (when creating a new package).Authors@R
,License
, andSuggests
still defer togetOption()
.Here's the result of my changes:
And immediately calling
document()
, which caused an error with the previous default value forAuthors@R
:Finally, after setting some options (temporarily):