add support for auth_token #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Could you please update the docs so that R CMD check passes? I'd also wonder if we should deprecate |
|
I think that would be preferred, if you're not worried about breaking backward compatibility. |
|
You can deprecate like |
|
The build seems to fail because docs are out of sync with code. Roxygenizing could help. (Perhaps Travis should run roxygenize to avoid this kind of error?) See also #397. |
|
@jeroenooms could you please re-roxygenise. Deprecation with a warning would also be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition for using an access token instead of username/password to authenticate. Access tokens can be generated by any user on https://github.com/settings/applications.
Access tokens are much preferred over username/password because they prevent the user from typing/hardcoding their password anywhere (which could end up in plain-text logs, etc). And if a token gets leaked, it can easily be revoked, and the attacker cannot use the token to change the Github password and lock-out the actual user.