Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible inconsistence with --no-vignettes option #2165

Closed
iagogv3 opened this issue Dec 17, 2019 · 2 comments
Closed

Possible inconsistence with --no-vignettes option #2165

iagogv3 opened this issue Dec 17, 2019 · 2 comments

Comments

@iagogv3
Copy link

iagogv3 commented Dec 17, 2019

I am running devtools::check(args = c('--as-cran','--no-vignettes')) to check the package sjPlot I've just modified a minor thing, but I get

...
-  installing the package to build vignettes
E  creating vignettes (57.7s)
...
   Error: processing vignette 'tab_bayes.Rmd' failed with diagnostics:
   schannel: failed to receive handshake, SSL/TLS connection failed
   --- failed re-building 'tab_bayes.Rmd'
...
   Error: processing vignette 'tab_model_estimates.Rmd' failed with diagnostics:
   there is no package called 'pscl'
   --- failed re-building 'tab_model_estimates.Rmd'
...
   Error: Vignette re-building failed.

Error in (function (command = NULL, args = character(), error_on_status = TRUE,  : 
  System command error
Calls: <Anonymous> ... with_envvar -> force -> do.call -> <Anonymous> -> throw

Exited with status 1.

where the errors are mainly there is no package called '...'.
I understand that with the option --no-vignettes, R code in vignettes is not run so I cannot see why these errors are produced.
This issue seems to be related to #1667

@jimhester
Copy link
Member

The error is happening when building the vignettes during R CMD build, before the R CMD check happens, so --no-vignettes has no effect. To disable vignettes completely you need to pass build_args = '--no-build-vignettes' as well.

But I think this is too much to ask people to know, so I have now added a vignette argument to check(), which will do both of these things for you.

@lock
Copy link

lock bot commented Jun 24, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants