Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools::check() does not respect --no-build-vignettes #1667

Closed
mkhezr opened this issue Dec 4, 2017 · 5 comments
Closed

devtools::check() does not respect --no-build-vignettes #1667

mkhezr opened this issue Dec 4, 2017 · 5 comments

Comments

@mkhezr
Copy link

mkhezr commented Dec 4, 2017

As suggested in R Packages - Automated Checking, I added --no-build-vignettes to the commands list in “Build Source Packages” field in the project options. And restarted Rstudio too. Still when I run devtools::check() the vignettes get built.

I'm running RStudio Version 1.0.153. and here is the output of R.version:

platform x86_64-apple-darwin15.6.0
arch x86_64
os darwin15.6.0
system x86_64, darwin15.6.0
status
major 3
minor 4.1
year 2017
month 06
day 30
svn rev 72865
language R
version.string R version 3.4.1 (2017-06-30)
nickname Single Candle

@jimhester
Copy link
Member

The --no-build-vignettes needs to go in the Check Package dialog to be added when running R CMD check() and the check needs to be run with build->Check from within RStudio to pick up the option.
screenshot 2018-02-13 15 35 20

@FMKerckhof
Copy link

FMKerckhof commented Apr 3, 2018

I am having a very similar issue, but I do have addedd --no-build--vignettes to the configure build tools:
image
Nevertheless, running build>Check keeps building vignettes ...
I am using Version 1.1.383 of Rstudio on a Ubuntu 17.10 desktop.
devtools::session_info() gives:


Session info ------------------------------------------------------------------------------------------
 setting  value                       
 version  R version 3.4.4 (2018-03-15)
 system   x86_64, linux-gnu           
 ui       RStudio (1.1.383)           
 language (EN)                        
 collate  en_US.UTF-8                 
 tz       Europe/Brussels             
 date     2018-04-03                  

Packages ----------------------------------------------------------------------------------------------
 package      * version date       source        
 base         * 3.4.4   2018-03-16 local         
 Biobase        2.38.0  2018-04-03 Bioconductor  
 BiocGenerics   0.24.0  2018-04-03 Bioconductor  
 cluster        2.0.7   2018-04-01 CRAN (R 3.4.4)
 compiler       3.4.4   2018-03-16 local         
 corpcor        1.6.9   2017-04-01 cran (@1.6.9) 
 datasets     * 3.4.4   2018-03-16 local         
 DEoptimR       1.0-8   2016-11-19 cran (@1.0-8) 
 devtools       1.13.5  2018-02-18 CRAN (R 3.4.4)
 digest         0.6.15  2018-01-28 CRAN (R 3.4.4)
 flowCore     * 1.44.2  2018-04-03 Bioconductor  
 graph          1.56.0  2018-04-03 Bioconductor  
 graphics     * 3.4.4   2018-03-16 local         
 grDevices    * 3.4.4   2018-03-16 local         
 grid           3.4.4   2018-03-16 local         
 lattice        0.20-35 2017-03-25 CRAN (R 3.4.4)
 matrixStats    0.53.1  2018-02-11 CRAN (R 3.4.4)
 memoise        1.1.0   2017-04-21 CRAN (R 3.4.1)
 methods      * 3.4.4   2018-03-16 local         
 mvtnorm        1.0-7   2018-01-26 CRAN (R 3.4.4)
 parallel       3.4.4   2018-03-16 local         
 pcaPP          1.9-73  2018-01-14 CRAN (R 3.4.3)
 Rcpp           0.12.16 2018-03-13 CRAN (R 3.4.4)
 robustbase     0.92-8  2017-11-01 CRAN (R 3.4.3)
 rrcov          1.4-3   2016-09-06 cran (@1.4-3) 
 stats        * 3.4.4   2018-03-16 local         
 stats4         3.4.4   2018-03-16 local         
 tools          3.4.4   2018-03-16 local         
 utils        * 3.4.4   2018-03-16 local         
 withr          2.1.2   2018-03-15 CRAN (R 3.4.4)
 yaml           2.1.16  2017-12-12 CRAN (R 3.4.3)

@jimhester
Copy link
Member

You actually need --no-build-vignettes in both the build and check steps to avoid building them completely.

@FMKerckhof
Copy link

Thanks Jim, that indeed was the case.

@lock
Copy link

lock bot commented Sep 30, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants