Skip to content

Commit

Permalink
Remove lang argument to spell_check
Browse files Browse the repository at this point in the history
For compatibility with spelling v1.1

Fixes #1715
  • Loading branch information
jimhester committed Feb 27, 2018
1 parent 2cce3ba commit 81ee98c
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Suggests:
rmarkdown,
roxygen2 (>= 5.0.0),
rversions,
spelling,
spelling (>= 1.1),
testthat (>= 1.0.2)
VignetteBuilder: knitr
Encoding: UTF-8
Expand Down
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ export(with_debug)
importFrom(cli,cat_bullet)
importFrom(cli,cat_line)
importFrom(cli,cat_rule)
importFrom(foghorn,cran_results)
importFrom(foghorn,summary_cran_details)
importFrom(memoise,memoise)
importFrom(pkgbuild,clean_dll)
importFrom(pkgbuild,has_devel)
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# devtools 1.13.3.9000

* The `lang` argument to `spell_check()` was removed, for compatibility with
[spelling](https://CRAN.R-project.org/package=spelling) v1.1.

* `check()` and `check_built()` now have an `error_on` argument to specify if
they should throw an error on check failures. When run non-interactively this
is set to "warnings" unless specified.
Expand Down
6 changes: 2 additions & 4 deletions R/spell-check.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
#' \code{\link{as.package}} for more information
#' @param vignettes include vignettes in the spell check; passed to
#' \link[spelling:spell_check_package]{spelling::spell_check_package}
#' @param lang a dictionary object or language string; passed to
#' \link[spelling:spell_check_package]{spelling::spell_check_package}
spell_check <- function(pkg = ".", vignettes = TRUE, lang = "en_US"){
spell_check <- function(pkg = ".", vignettes = TRUE){
pkg <- as.package(pkg)
spelling::spell_check_package(pkg = pkg, vignettes = vignettes, lang = lang)
spelling::spell_check_package(pkg = pkg, vignettes = vignettes)
}
5 changes: 1 addition & 4 deletions man/spell_check.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 81ee98c

Please sign in to comment.