Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mockery #59

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Remove mockery #59

merged 6 commits into from
Aug 28, 2024

Conversation

jonthegeek
Copy link
Contributor

Fixes #57

I don't love the implementation I used in package.R. If there's a less-kludgey way to do that, I'd be happy implement it (and learn the trick)!

Fixes r-lib#57

I don't love the implementation for package.R. If there's a less-kludgey way to do that, I'd be happy to do so!
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few style nitpicks to fix

R/debug.R Outdated Show resolved Hide resolved
tests/testthat/test-debug.R Outdated Show resolved Hide resolved
R/package.R Outdated Show resolved Hide resolved
@gaborcsardi
Copy link
Member

gaborcsardi commented Aug 28, 2024

Thanks much! I simplified it a bit and avoided some mocks. This would mess up debugme if it was used while running the tests, but that's quite unlikely.

@gaborcsardi gaborcsardi merged commit 121258f into r-lib:main Aug 28, 2024
13 checks passed
Copy link
Contributor Author

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't feel great about how I implemented things, but didn't have a better solution that kept testing roughly equivalent. It's useful to see what you did!

@jonthegeek jonthegeek deleted the demockery branch August 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use testthat::with_mock() instead of mockery
3 participants