Preliminary fix for message timing with cli_progress_along()
(#668)
#792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue seems to be that message printing was just looking at
show_after
value which is fixed. I believe the change below is the desired behavior where we comparenow
withshow_after
+last_shown
instead.The code is a bit convoluted because we need to grab
last_shown
which does not necessarily exist. If it is not yet defined then I've defaulted to -Inf so that the first iteration will always print regardless ofshow_after
.Fix #668