Compress transport #223
Merged
Compress transport #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the function in the child session.
|
Looks great! Can you please add a bullet point to the NEWS, referring to this PR, and also your GitHub username. Thanks again! I'll take a quick look to see if we could test this somehow. |
|
Failing tests seems to be related to changes in processx, perhaps: r-lib/processx@12b2419 Do you want me to update this as part of this PR? |
Ooops, no, don't worry about it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222
I couldn't find a good way to test this besides comparing execution time compressing versus not compressing... but this doesn't seem to be reliable.