-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all functions to use "_" instead of "." #12
Comments
Created the branch |
@cbeleites @eoduniyi has completed this issue but I was wondering if this change requires some kind of deprecation. If no, please close this issue. |
For exported functions only, these changes should be mentioned in |
And when issue cbeleites/hyperSpec#263 is solved, I'll add proper deprecation messages to relevant functions in hyperSpec (as I did with hySpc.ggplot2). |
PR #26 closes this issue |
Rename all the functions like
read.txt.Witec()
intoread_txt_Witec()
. In particular, function names should be the same as filenames that contain those functions, e.g., in https://github.com/r-hyperspec/hySpc.read.Witec/blob/develop/R/read_txt_Witec.Rhttps://github.com/r-hyperspec/hySpc.read.Witec/blob/16a57f09b1c149e43d3f31d9284f740bc808e825/R/read_txt_Witec.R#L24
There are several not renamed functions including
read.mat.Witec()
,read.dat.Witec()
, andread.txt.Witec()
.The text was updated successfully, but these errors were encountered: