Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all functions to use "_" instead of "." #12

Closed
GegznaV opened this issue Aug 10, 2020 · 5 comments
Closed

Rename all functions to use "_" instead of "." #12

GegznaV opened this issue Aug 10, 2020 · 5 comments
Assignees

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 10, 2020

Rename all the functions like read.txt.Witec() into read_txt_Witec(). In particular, function names should be the same as filenames that contain those functions, e.g., in https://github.com/r-hyperspec/hySpc.read.Witec/blob/develop/R/read_txt_Witec.R
https://github.com/r-hyperspec/hySpc.read.Witec/blob/16a57f09b1c149e43d3f31d9284f740bc808e825/R/read_txt_Witec.R#L24

There are several not renamed functions including read.mat.Witec(), read.dat.Witec(), and read.txt.Witec().

@eoduniyi eoduniyi self-assigned this Aug 17, 2020
@eoduniyi
Copy link
Contributor

Created the branch feature-12-rename.2_ to take care of this issue

@bryanhanson
Copy link
Collaborator

@cbeleites @eoduniyi has completed this issue but I was wondering if this change requires some kind of deprecation. If no, please close this issue.

@GegznaV
Copy link
Member Author

GegznaV commented Aug 18, 2020

For exported functions only, these changes should be mentioned in NEWS.md in hyperSpec repo.

@GegznaV
Copy link
Member Author

GegznaV commented Aug 18, 2020

And when issue cbeleites/hyperSpec#263 is solved, I'll add proper deprecation messages to relevant functions in hyperSpec (as I did with hySpc.ggplot2).

@eoduniyi
Copy link
Contributor

PR #26 closes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants