Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all appropriate functions to hySpc.read.txt package #263

Closed
24 tasks done
GegznaV opened this issue Aug 18, 2020 · 5 comments
Closed
24 tasks done

Move all appropriate functions to hySpc.read.txt package #263

GegznaV opened this issue Aug 18, 2020 · 5 comments
Assignees
Labels
Type: enhancement 🎈 asking for a new feature.

Comments

@GegznaV
Copy link
Collaborator

GegznaV commented Aug 18, 2020

  1. Copy all functions that read data from text/ASCII files to package hySpc.read.txt
  2. In hyperSpec, add concept #' @concept moved to hySpc.read.txt to the documentation of each function that is copied to hySpc.read.txt
    • NOTE: functions should not be removed from hyperSpec for now (for backward compatibility), just the concept should be added.
  3. In NEWS.md, the list of copied functions should be added. It should be stated, that "these functions were moved to hySpc.read.txt and will be removed from hyperSpec in the next release"

We will solve other related issues later.

Related: r-hyperspec/hySpc.read.txt#22


UPDATE

Make sure that the following functions are moved to hySpc.read.txt (there are file name and functions in that file)

  • read.txt.Horiba.R
    • read.txt.Horiba
    • read.txt.Horiba.xy
    • read.txt.Horiba.t
  • read.txt.long.R
    • read.txt.long
  • read.txt.Renishaw.R
    • read.txt.Renishaw
    • read.zip.Renishaw
  • read.txt.Shimadzu.R
    • read.txt.Shimadzu
  • read.txt.wide.R
    • read.txt.wide
  • read.txt.Witec.R
    • read.txt.Witec
    • read.dat.Witec
    • read.txt.Witec.Graph
  • wc.R
    • wc
  • count_lines.R
    • count_lines
  • read.asc.Andor.R
    • read.asc.Andor
  • read.asc.PerkinElmer.R
    • read.asc.PerkinElmer

You can find these files and functions here: move-to--hySpc-read-txt.zip

The following files (and functions in them) should not be moved to hySpc.read.txt as the functions are used not only in hySpc.read.txt but also elsewhere:

  • fileio.optional.R
@eoduniyi eoduniyi self-assigned this Aug 18, 2020
@eoduniyi eoduniyi added the Type: enhancement 🎈 asking for a new feature. label Aug 18, 2020
@eoduniyi
Copy link
Collaborator

This is the same as issue #22 in hypSpc.read.txt

@GegznaV
Copy link
Collaborator Author

GegznaV commented Aug 18, 2020

@eoduniyi I updated the description of this issue above. I noticed that the list in r-hyperspec/hySpc.read.txt#22 was to short and not accurate enough so I created a new list (see above). Please, check if all functions in the list above are moved to hySpc.read.txt. One function should not be moved.

@GegznaV GegznaV changed the title Move all apropriate functions to hySpc.read.txt package Move all appropriate functions to hySpc.read.txt package Aug 18, 2020
@cbeleites
Copy link
Owner

@GegznaV thank you for compiling the list. I removed wc() since it is already (soft) deprecated.
It is not used any more: I fixed the documentation in hySpc.read.txt::read_txt_Renishaw() and hyperSpec::read.txt.Renishaw().

@eoduniyi
Copy link
Collaborator

eoduniyi commented Aug 20, 2020

This issue was closed by PR r-hyperspec/hySpc.read.txt#26 from hypSpc.read.txt

@GegznaV
Copy link
Collaborator Author

GegznaV commented Aug 20, 2020

You may link the issues in other repos by adding full repo name (with organization/author name) before issue number r-hyperspec/hySpc.read.txt#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement 🎈 asking for a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants