Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifecycle of a patch #6

Merged
merged 20 commits into from
May 25, 2021
Merged

Conversation

SaranjeetKaur
Copy link
Collaborator

@SaranjeetKaur SaranjeetKaur commented Apr 14, 2021

This chapter describes the lifecycle of a patch and how to review patches in R.

@SaranjeetKaur SaranjeetKaur marked this pull request as draft April 14, 2021 15:08
@SaranjeetKaur SaranjeetKaur marked this pull request as ready for review April 15, 2021 15:35
Copy link
Member

@llrs llrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great chapter! It was easy to follow and very well linked. I have some comments about the some paragraphs but it looks great.

05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Show resolved Hide resolved
SaranjeetKaur and others added 2 commits April 15, 2021 23:38
Co-authored-by: Lluís <llrs@users.noreply.github.com>
Co-authored-by: Lluís <llrs@users.noreply.github.com>
Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Saranjeet! Needs a bit of restructuring to make it easier to follow, plus a few minor changes.

05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
05-lifecycle_of_a_Patch.Rmd Outdated Show resolved Hide resolved
@SaranjeetKaur SaranjeetKaur changed the title [WIP] Lifecycle of a patch Lifecycle of a patch May 14, 2021
@SaranjeetKaur SaranjeetKaur merged commit 419720c into r-devel:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants