Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove call to encodeString() in dbQuoteIdentifier() #765

Merged
merged 2 commits into from
Feb 27, 2024
Merged

remove call to encodeString() in dbQuoteIdentifier() #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0653f9d
remove call to `encodeString()` in `dbQuoteIdentifier()`
simonpcouch Feb 26, 2024
8da14a8
add note in NEWS
simonpcouch Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

* Teradata: Resolved issue when previewing tables using the Connections pane.

* The `"OdbcConnection"` method for `dbQuoteIdentifier()` will no longer
pass `x` to `encodeString()` before returning, for consistency with the
default implementation in DBI (@simonpcouch, #765).

# odbc 1.4.2

Expand Down
2 changes: 1 addition & 1 deletion R/dbi-connection.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ setMethod("dbQuoteIdentifier", c("OdbcConnection", "character"),
x <- gsub(conn@quote, paste0(conn@quote, conn@quote), x, fixed = TRUE)
}
nms <- names(x)
res <- DBI::SQL(paste(conn@quote, encodeString(x), conn@quote, sep = ""))
res <- DBI::SQL(paste(conn@quote, x, conn@quote, sep = ""))
names(res) <- nms
res
}
Expand Down
Loading