Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server: correctly enumerate out of catalog schemas #692

Merged
merged 12 commits into from
Dec 20, 2023

Conversation

detule
Copy link
Collaborator

@detule detule commented Dec 19, 2023

Closes #672 and #527

@detule detule force-pushed the mssql/out_of_catalog_schemas branch from 2aa43ef to a0e5ac1 Compare December 19, 2023 01:08
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just gave a lot of very detailed style comments 😄

R/driver-sql-server.R Outdated Show resolved Hide resolved
R/driver-sql-server.R Outdated Show resolved Hide resolved
tests/testthat/test-driver-sql-server.R Outdated Show resolved Hide resolved
tests/testthat/test-driver-sql-server.R Outdated Show resolved Hide resolved
R/driver-sql-server.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

NEWS.md Outdated Show resolved Hide resolved
detule and others added 6 commits December 19, 2023 19:17
Co-authored-by: Hadley Wickham <hadley@posit.co>
Co-authored-by: Hadley Wickham <hadley@posit.co>
Co-authored-by: Hadley Wickham <hadley@posit.co>
Co-authored-by: Hadley Wickham <hadley@posit.co>
Co-authored-by: Hadley Wickham <hadley@posit.co>
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
@detule
Copy link
Collaborator Author

detule commented Dec 20, 2023

Thanks fellas, appreciate it.

@detule detule merged commit 99cde21 into r-dbi:main Dec 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odbcConnectionSchemas() should only dispatch on conn
3 participants