Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export S4 classes that we create #668

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Export S4 classes that we create #668

merged 1 commit into from
Dec 12, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Dec 12, 2023

This makes it possible for other packages to import them, without creating clashing definitions. Fixes #558.

This makes it possible for other packages to import them, without creating clashing definitions. Fixes #558.
@hadley hadley requested a review from detule December 12, 2023 13:33
@detule
Copy link
Collaborator

detule commented Dec 12, 2023

LGTM / thanks for fixing the inheritance.

@hadley hadley merged commit e108c10 into main Dec 12, 2023
16 checks passed
@hadley hadley deleted the export-classes branch December 12, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: invalid names for slots of class “Microsoft SQL Server”: ptr, quote, info, encoding
2 participants