-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workshop docs for odbcListDrivers()
and odbcListDataSources()
#649
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are many comments to hopefully help get my mental model in your head and hence in the heads of users 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
When getting started, I initially had trouble figuring out how to get a driver / DSN correctly configured. It seemed the existing docs assumed I had a connection configured already, though
?odbcListDataSources()
directed folks to the README if they happen to stumble across it.As of #647, we now direct people to
?odbcListDataSources()
and?odbcListDrivers()
from the?dbConnect()
docs. This PR revamps the docs for those pages.After this PR, I'd like to revisit the installation docs in the
README
andsetup.md
. I thinkREADME
could be a strong venue to establish the mental model and link out to other places for the nitty gritty. I do see the benefits of listing out all of the rightbrew install
orapt-get
incantations in one place, though that content seems 1) more developer-focused, as many docs I've seen online seem to imply that a user is likely to be working in a context where those drivers are already installed, and 2) well-served by good setup helpers (see #634).