-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix box_delete_folder() #200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 55.88% 58.16% +2.28%
==========================================
Files 24 26 +2
Lines 1555 1788 +233
==========================================
+ Hits 869 1040 +171
- Misses 686 748 +62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome bug/confusion fix and more test coverage?!? Love it.
Merge commit '64220094018d5cc23f2bd300c2d5bd44fa9084a5' Conflicts: DESCRIPTION
…boxr into fix-197-box_delete_folder
Did we double fix the conflicts? Sorry should have communicated better...but looks like this will build green and then we can Squash and Merge |
there's no problem at all - this is what I had intended to - to pull the other changes into this PR, make sure it all plays nicely together before merging. sometimes the version numbers collide, that's all this is |
Got it okay, I saw the other was .13 and this was .14 so I was gonna merge in that order. Just didn't want to be making more work for you |
We're on our way! |
fix #197
The file and folder API calls return empty content, by Box' design.
In
box_delete_folder()
, we were trying to parse the empty content - leading to the error.Fixed this, along with a stray documentation fix.
I found that using
r string_side_effects()
was not working within a{}
structure, so I pasted it in manually.