Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix box_delete_folder() #200

Merged
merged 10 commits into from
Jan 18, 2021
Merged

fix box_delete_folder() #200

merged 10 commits into from
Jan 18, 2021

Conversation

ijlyttle
Copy link
Member

@ijlyttle ijlyttle commented Jan 17, 2021

fix #197

The file and folder API calls return empty content, by Box' design.

In box_delete_folder(), we were trying to parse the empty content - leading to the error.

Fixed this, along with a stray documentation fix.

I found that using r string_side_effects() was not working within a {} structure, so I pasted it in manually.

@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #200 (eb3ea49) into master (8bbdea7) will increase coverage by 2.28%.
The diff coverage is 66.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   55.88%   58.16%   +2.28%     
==========================================
  Files          24       26       +2     
  Lines        1555     1788     +233     
==========================================
+ Hits          869     1040     +171     
- Misses        686      748      +62     
Impacted Files Coverage Δ
R/boxr_add_description.R 0.00% <ø> (ø)
R/boxr_comment.R 0.00% <0.00%> (ø)
R/boxr_dir_verbs.R 99.10% <ø> (ø)
R/boxr_save_load.R 0.00% <0.00%> (ø)
R/boxr_search.R 0.00% <ø> (ø)
R/boxr_source.R 100.00% <ø> (ø)
R/boxr_upload_download.R 76.19% <ø> (ø)
R/utils-documentation.R 0.00% <0.00%> (ø)
R/zzz.R 13.33% <0.00%> (-0.96%) ⬇️
R/boxr_misc.R 46.08% <20.00%> (+1.44%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6422009...eb3ea49. Read the comment docs.

@ijlyttle ijlyttle requested a review from nathancday January 17, 2021 19:48
@ijlyttle ijlyttle mentioned this pull request Jan 17, 2021
17 tasks
Copy link
Member

@nathancday nathancday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome bug/confusion fix and more test coverage?!? Love it.

nathancday and others added 3 commits January 18, 2021 13:53
Merge commit '64220094018d5cc23f2bd300c2d5bd44fa9084a5'

Conflicts:
	DESCRIPTION
@nathancday
Copy link
Member

Did we double fix the conflicts? Sorry should have communicated better...but looks like this will build green and then we can Squash and Merge

@ijlyttle
Copy link
Member Author

there's no problem at all - this is what I had intended to - to pull the other changes into this PR, make sure it all plays nicely together before merging.

sometimes the version numbers collide, that's all this is

@nathancday
Copy link
Member

Got it okay, I saw the other was .13 and this was .14 so I was gonna merge in that order. Just didn't want to be making more work for you

@ijlyttle ijlyttle merged commit ded836b into master Jan 18, 2021
@ijlyttle
Copy link
Member Author

We're on our way!

@ijlyttle ijlyttle deleted the fix-197-box_delete_folder branch January 18, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in box_delete_folder()
3 participants