Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rpp Performance Test Suite #229

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Rpp Performance Test Suite #229

merged 4 commits into from
Jan 31, 2024

Conversation

HazarathKumarM
Copy link

  • Add a batchPD column in the excel summary
  • print the excel summary in console

@sampath1117
Copy link
Collaborator

Summary to be displayed as below
image (21)

Command line argument
python runTests.py --case_list 21 36 63 --test_type 1 --qa_mode 1 --batch_size 8 --num_runs 100

r-abishek
r-abishek reviewed Jan 30, 2024
View reviewed changes
Copy link
Owner

@r-abishek r-abishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls leave a screenshot of the native python / pandas print style.

utilities/test_suite/HOST/runTests.py Outdated
'Test_Result': f'Final Results of Tests: Passed: {passedCases}, Failed: {failedCases}'}

print("\n",tabulate(df, headers = 'keys', tablefmt = 'psql'))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just do a print(df) here?
Or any simpler display that uses just pandas? Since tabulate is a new dependency and we'll have to add it in the CI for automated testing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

utilities/test_suite/HOST/runTests.py Outdated
@@ -25,6 +25,7 @@
import datetime
import shutil
import pandas as pd
from tabulate import tabulate
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check, and we can remove the import

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@r-abishek r-abishek added the enhancement New feature or request label Jan 30, 2024
@HazarathKumarM
Copy link
Author

@r-abishek removed the tabulate import and using default pandas method to print the output
Here is the image of the summary printed to console
image

r-abishek
r-abishek reviewed Jan 31, 2024
View reviewed changes
utilities/test_suite/README.md
@@ -85,6 +85,11 @@ This repository contains three test suites for the AMD ROCm Performance Primitiv
pip install openpyxl
```

* Tabulate
```
pip install tabulate
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dependency

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it post merge

r-abishek
r-abishek approved these changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@r-abishek r-abishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm / tabulate dependency to be removed

@r-abishek r-abishek merged commit 407360d into r-abishek:ar/test_suite_upgrade_5_qa_perf Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-abishek r-abishek r-abishek approved these changes

Assignees

@sampath1117 sampath1117

@HazarathKumarM HazarathKumarM

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazarathKumarM @sampath1117 @r-abishek