Fixed a bug when in single_active_consumer mode and deliver frame with more than one message, the result of the consumer_update_listener function was ignored. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h more than one message, the result of the consumer_update_listener function was ignored.
| await run_consumer(super_stream_consumer_for_sac3, consumer_stream_list3, consumer_update_handler_offset) | ||
| await run_consumer(super_stream_consumer_for_sac1, consumer_stream_list1, consumer_update_handler_first) | ||
| await run_consumer(super_stream_consumer_for_sac2, consumer_stream_list2, consumer_update_handler_first) | ||
| await run_consumer(super_stream_consumer_for_sac3, consumer_stream_list3, consumer_update_handler_first) |
There was a problem hiding this comment.
@nesb1 With this modification in place should this test still work with the original consumer_update_handler_offset?
There was a problem hiding this comment.
No, thist test will not work with consumer_update_handler_offset. Test checks that total count of all consumed messages equals to total count of all produced messages. consumer_update_handler_offset overides offset to consume from 10 message in stream, not from first, which means that total count of all consumed messages must be less than total count of all produced messages by 3 * 10 messages
DanielePalaia
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
Fixed a bug when in single_active_consumer mode and deliver frame with more than one message, the result of the consumer_update_listener function was ignored.