Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelling background task before publishing remaining items #190

Merged
merged 1 commit into from
May 2, 2024
Merged

cancelling background task before publishing remaining items #190

merged 1 commit into from
May 2, 2024

Conversation

DanielePalaia
Copy link
Collaborator

@DanielePalaia DanielePalaia commented Apr 24, 2024 •
edited
Loading

This will avoid an asyncio.CancelledError in _publish_buffered_messages during the close() of the Producer that sometimes happens

@DanielePalaia DanielePalaia marked this pull request as draft April 24, 2024 14:44
@DanielePalaia DanielePalaia marked this pull request as ready for review May 2, 2024 08:03
@DanielePalaia DanielePalaia merged commit 03efdda into master May 2, 2024
1 check passed
@DanielePalaia DanielePalaia deleted the fix_bug_during_producer_close branch May 2, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gsantomaggio Gsantomaggio Gsantomaggio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielePalaia @Gsantomaggio