-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedups for encoding.py #100
Conversation
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@qweeze looking |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@qweeze, we have tried to understand the problem without success. We tried 3.9 and 3.11, and there were different errors. The performances are better, and it is worth investigating. |
Seems to be a library issue, perhaps versions bump will help? |
That's a good question. I tend to be conservative but if it is necessary we can bump the requirement to 3.10. @lukebakken @DanielePalaia WDYT about? |
Technically we should support Python 3.8 and beyond - https://devguide.python.org/versions/ |
HI @qweeze it seems like that a syntax like: 'EnumMeta' | 'NoneType' is not supported by Python 3.9 Is the | None really necessary here? The tests seem passing anyway without it. |
replaced it with |
thanks @qweeze ! |
No description provided.