Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedups for encoding.py #100

Merged
merged 10 commits into from
Jul 18, 2023
Merged

Speedups for encoding.py #100

merged 10 commits into from
Jul 18, 2023

Conversation

Gsantomaggio
Copy link
Collaborator

No description provided.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio
Copy link
Collaborator Author

@qweeze looking rstream/schema.py:7: error: Module "typing" has no attribute "TypeGuard" any idea?

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio
Copy link
Collaborator Author

@qweeze, we have tried to understand the problem without success. We tried 3.9 and 3.11, and there were different errors. The performances are better, and it is worth investigating.

@qweeze
Copy link
Owner

qweeze commented Jul 17, 2023

Module "typing" has no attribute "TypeGuard"

TypeGuard was only introduced in python 3.10, so we can't use it if we want to support older python versions. I removed it here b658976
BTW, should we support python < 3.10?

KeyError: '__spec__'

Seems to be a library issue, perhaps versions bump will help?

@Gsantomaggio
Copy link
Collaborator Author

BTW, should we support python < 3.10?

That's a good question. I tend to be conservative but if it is necessary we can bump the requirement to 3.10.

@lukebakken @DanielePalaia WDYT about?

@lukebakken
Copy link

Technically we should support Python 3.8 and beyond - https://devguide.python.org/versions/

@DanielePalaia
Copy link
Collaborator

DanielePalaia commented Jul 17, 2023

HI @qweeze it seems like that a syntax like:

'EnumMeta' | 'NoneType' is not supported by Python 3.9

Is the | None really necessary here? The tests seem passing anyway without it.

@qweeze
Copy link
Owner

qweeze commented Jul 17, 2023

Is the | None really necessary here?

replaced it with Optional (which is basically the same, but with old syntax), seems to be working now

@Gsantomaggio
Copy link
Collaborator Author

thanks @qweeze !
looks good to me!

@Gsantomaggio Gsantomaggio mentioned this pull request Jul 18, 2023
@Gsantomaggio Gsantomaggio merged commit 99ffc9b into master Jul 18, 2023
1 check passed
@Gsantomaggio Gsantomaggio deleted the feat/encoding-optimizations branch July 18, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants