-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query templates #27
Query templates #27
Conversation
869994d
to
4820f2c
Compare
4820f2c
to
522d695
Compare
This is great, a long standing feature getting implemented!
|
WithOptions(...) -> WithData(...) and take any rather than a map.
In 522d695 But the WithData(...) call cannot fail because it doesn't yet know which query you're executing - it would have to try each query with that data. Have acted on the other comments though :) |
Any thoughts @qustavo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good now!
just added one more comment and I think we are good to go.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks much cleaner now, thank for applying the changes.
I've added some test remarks.
a277fd9
to
5a2e680
Compare
@kayrein added you as a member, do you think you can cut a new release including this? |
Introduce support for text interpolation