Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCR-D v3 API: fixes #134

Merged
merged 3 commits into from
Sep 2, 2024
Merged

OCR-D v3 API: fixes #134

merged 3 commits into from
Sep 2, 2024

Conversation

bertsky
Copy link
Contributor

@bertsky bertsky commented Sep 2, 2024

  • The current pyproject.toml does not install eynollah as a namespace pkg in qurator namespace anymore – dfc4ac2 fixes that.
  • If indeed a namespace pkg is present, then ocrd==3.0.0b2 still does not work, because importlib_resources says Can't open orphan pathOCR-D/core@1ed38a6 fixes that in core, 1e90257 here.
  • The fileGrp cardinalities were still not in the tool json – 17eafc1 fixes that.

@kba
Copy link
Contributor

kba commented Sep 2, 2024

  • The current pyproject.toml does not install eynollah as a namespace pkg in qurator namespace anymore – dfc4ac2 fixes that.

We have got rid of the namespace, as of #133, so at least for eynollah that should not be a problem anymore.

* If indeed a namespace pkg is present, then ocrd==3.0.0b2 still does not work, because importlib_resources says `Can't open orphan path` – [OCR-D/core@1ed38a6](https://github.com/OCR-D/core/commit/1ed38a6a7559bc0c109e8130220de49698796efd) fixes that in core, [1e90257](https://github.com/qurator-spk/eynollah/commit/1e902571ead1b8493376e2ca7d1dc401aefd929d) here.

Still good that the namespace case is addressed in metadata_location.

* The fileGrp cardinalities were still not in the tool json – [17eafc1](https://github.com/qurator-spk/eynollah/commit/17eafc1ccb3980f2bedb5183d45942fc83a838ba) fixes that.

🙏

So, I'll merge this and then merge main, then we should have an up-to-date v3 PR again.

@kba kba merged commit 9b274dc into qurator-spk:v3-api Sep 2, 2024
@bertsky
Copy link
Contributor Author

bertsky commented Sep 2, 2024

We have got rid of the namespace, as of #133, so at least for eynollah that should not be a problem anymore.

Oh, I was not aware of this. But my dfc4ac2 will break this – in the sense that qurator namespace gets reintroduced, because setuptools autodetects this case, structurally. (You have to pass where to tell it otherwise.)

May I ask what was the motivation for that? All the other tools by the Qurator team still use that namespace...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants