Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Babel presets fixes #423

Merged
merged 4 commits into from
Aug 6, 2016
Merged

Babel presets fixes #423

merged 4 commits into from
Aug 6, 2016

Conversation

mmahalwy
Copy link
Contributor

@mmahalwy mmahalwy commented Aug 6, 2016

No description provided.

@mmahalwy mmahalwy temporarily deployed to quran-frontend-pr-423 August 6, 2016 21:11 Inactive
@ahmedre
Copy link
Contributor

ahmedre commented Aug 6, 2016

awesome jazakAllah khairan!

@thabti
Copy link
Contributor

thabti commented Aug 6, 2016

+1

@mmahalwy
Copy link
Contributor Author

mmahalwy commented Aug 6, 2016

@ahmedre i did. See https://github.com/quran/quran.com-frontend/pull/423/files#diff-5f694022cd10cae14c85a89025b45c45R42

@ahmedre
Copy link
Contributor

ahmedre commented Aug 6, 2016

/quran/node_modules/extract-text-webpack-plugin/index.js:171
        throw new Error("Breaking change: extract now only takes a single argument. Either an options " +
        ^

Error: Breaking change: extract now only takes a single argument. Either an options object *or* the loader(s).
Example: if your old code looked like this:
    ExtractTextPlugin.extract('style-loader', 'css-loader')

You would change it to:
    ExtractTextPlugin.extract({ fallbackLoader: 'style-loader', loader: 'css-loader' })

The available options are:
    loader: string | object | loader[]
    fallbackLoader: string | object | loader[]
    publicPath: string

    at Function.ExtractTextPlugin.extract (/quran/node_modules/extract-text-webpack-plugin/index.js:171:9)
    at Object.<anonymous> (/quran/webpack/prod.config.js:62:52)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at module.exports (/quran/node_modules/webpack/bin/convert-argv.js:93:13)
    at Object.<anonymous> (/quran/node_modules/webpack/bin/webpack.js:126:40)

@mmahalwy mmahalwy temporarily deployed to quran-frontend-pr-423 August 6, 2016 21:16 Inactive
@mmahalwy mmahalwy temporarily deployed to quran-frontend-pr-423 August 6, 2016 21:19 Inactive
@mmahalwy mmahalwy temporarily deployed to quran-frontend-pr-423 August 6, 2016 21:24 Inactive
@ahmedre
Copy link
Contributor

ahmedre commented Aug 6, 2016

Deployed to: http://staging.quran.com:32771

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants