This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Audioplayer repeats #388
Merged
Audioplayer repeats #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:32769 |
mmahalwy
force-pushed
the
audioplayer-repeats
branch
from
f79de0f
to
d6f0cd8
Compare
|
Deployed to: http://staging.quran.com:32780 |
added 4 commits
July 10, 2016 14:49
| import { decrypt } from 'sjcl'; | ||
| import Helmet from 'react-helmet'; | ||
|
|
||
| import debug from 'helpers/debug'; |
There was a problem hiding this comment.
How is this alias configured?
There was a problem hiding this comment.
@sabeurthabti not an alias but prefilling the namespace for the debug lib. https://github.com/quran/quran.com-frontend/blob/master/src/helpers/debug.js
mmahalwy
force-pushed
the
audioplayer-repeats
branch
from
d6f0cd8
to
f959d87
Compare
|
Deployed to: http://staging.quran.com:32794 |
| } | ||
| ) | ||
| export default class Audioplayer extends Component { | ||
| export class Audioplayer extends Component { |
There was a problem hiding this comment.
nice! exporting the class to make it testable.
|
UI reviewed and code reviewed. All Good. |
|
thank you sir! LEts merge this |
thabti
pushed a commit
to thabti/quran.com-frontend
that referenced
this pull request
Jul 23, 2016
* Audioplayer repeat * ui * wip * tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.