Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Player and Go to verse issues #760

Closed
naveed-ahmad opened this issue Apr 24, 2017 · 3 comments
Closed

Player and Go to verse issues #760

naveed-ahmad opened this issue Apr 24, 2017 · 3 comments
Labels
help wanted

Comments

@naveed-ahmad
Copy link
Contributor

Player and go to verse dropdown has multiple conflicts:

Steps to reproduce issues:

  • Go to any Surah
  • Play the first verse
  • Select any verse from go to verse dropdown
  • 1: Player will now play multiple verses simultaneously. Pause btn in player bar won't stop first recitation.
  • 2: Go to 2/1, then select verse from dropdown which isn't loaded yet(> 10, say user select 30). Now user can't see first 10 verses yet player will keep playing them. BAD UX

IMO: Go to verse should stop currently playing verse and start playing selected one.
mmahalwy added a commit that referenced this issue Apr 30, 2017
@mmahalwy
Fixes #760 verse dropdown and audio player
67a4fc8
@AhmedShab
Copy link
Contributor

AhmedShab commented May 17, 2017 •
edited
Loading

@naveed-ahmad I will look into this if you like 😄

@AhmedShab
Copy link
Contributor

It looks like Mohamed is working on it. In that case, I can look for something else

@mmahalwy
Copy link
Contributor

I think this is fixed no?

mmahalwy added a commit that referenced this issue May 27, 2017
@mmahalwy
Audio bugs (#772)
b3378ee 
* Fixes #761 multiple playing

* Fixes #760 verse dropdown and audio player

* Fix translation error at end of surah

* Fix on first load loading file

* Reading mode audio + reading mode segment

* react component
@snyk-bot snyk-bot mentioned this issue Mar 12, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naveed-ahmad @mmahalwy @AhmedShab