Merge pull request #2049 from quran/fix-translations-always-showing-bug

Force-remove translations depending on user preferences
quran · Nov 29, 2023 · 9bb28d5 · 9bb28d5
2 parents 3f8eb0e + b1ee61f
commit 9bb28d5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...components/QuranReader/TranslationView/TranslationViewVerse/hooks/useDedupedFetchVerse.ts b/...components/QuranReader/TranslationView/TranslationViewVerse/hooks/useDedupedFetchVerse.ts
@@ -112,8 +112,16 @@ const useDedupedFetchVerse = ({
         )
       : null;
 
+  const verse = verses ? verses[idxInPage] : null;
+
+  // This part handles an edge case where the user has no selected translations but the `initialData` sent from server-side rendering has a default translation.
+  // So, we need to remove the translations from the verse if the user has no selected translations.
+  if (verse && selectedTranslations.length === 0) {
+    verse.translations = [];
+  }
+
   return {
-    verse: verses ? verses[idxInPage] : null,
+    verse,
     firstVerseInPage: verses ? verses[0] : null,
     bookmarksRangeUrl,
     notesRange: verses