mypy: make quixstreams.models.* pass type checks #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentin-quix
force-pushed
the
mypy-models
branch
2 times, most recently
from
8f45d03 to
298b907
Compare
quentin-quix
force-pushed
the
mypy-models
branch
from
298b907 to
bc2a9d0
Compare
partition/offset can only be none if the msg is an error key/values/headers can always be none
quentin-quix
force-pushed
the
mypy-models
branch
from
9fc7ba1 to
a9807df
Compare
daniil-quix
reviewed
Dec 6, 2024
daniil-quix
reviewed
Dec 6, 2024
daniil-quix
previously approved these changes
Dec 6, 2024
daniil-quix
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.