Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-multitenacy #150

Merged
merged 4 commits into from
Jul 21, 2021
Merged

remove-multitenacy #150

merged 4 commits into from
Jul 21, 2021

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jul 16, 2021

This PR removes the concept of tentants from Owl. It was never used in production, made everything more complicated, and generally based on false assumptions. Let's roll back :)

@coveralls
Copy link

coveralls commented Jul 16, 2021

Pull Request Test Coverage Report for Build 1052923481

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 74 of 76 (97.37%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.9%) to 87.47%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/shared/stale-checker.ts 22 24 91.67%
Files with Coverage Reduction New Missed Lines %
src/producer/producer.ts 1 90.85%
src/shared/tracer.ts 2 86.67%
src/redis-commands.ts 3 75.0%
Totals Coverage Status
Change from base Build 1052922955: -0.9%
Covered Lines: 437
Relevant Lines: 464

💛 - Coveralls

@Skn0tt Skn0tt marked this pull request as ready for review July 21, 2021 14:44
@Skn0tt Skn0tt merged commit 38bfa52 into main Jul 21, 2021
@Skn0tt Skn0tt deleted the remove-multitenacy branch July 21, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants