This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Stop processors when fatal errors occur #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=========================================
Coverage ? 94.73%
=========================================
Files ? 29
Lines ? 2452
Branches ? 286
=========================================
Hits ? 2323
Misses ? 84
Partials ? 45
Continue to review full report at Codecov.
|
abaiken
changed the title
myersCody
approved these changes
Oct 2, 2019
kholdaway
suggested changes
Oct 3, 2019
kholdaway
reviewed
Oct 3, 2019
kholdaway
reviewed
Oct 3, 2019
kholdaway
reviewed
Oct 3, 2019
…a processor utils module
|
I retested the critical error using the methods used in the description and it worked for me! 👍 |
myersCody
approved these changes
Oct 8, 2019
abaiken
added a commit
that referenced
this pull request
Oct 11, 2019
* Remove report archives from postgresDB after specified time (#233) * initial changes to add a garbage collector. * Scheduled monthly dependency update for September (#237) * Update requests-mock from 1.6.0 to 1.7.0 * Update requests-mock from 1.6.0 to 1.7.0 * Update sphinx from 2.1.2 to 2.2.0 * Update sphinx from 2.1.2 to 2.2.0 * Update lazy-object-proxy from 1.4.1 to 1.4.2 * Update port-for from 0.3.1 to 0.4 * Update virtualenv from 16.7.2 to 16.7.4 * Update zipp from 0.5.2 to 0.6.0 * Add Grafana & Prometheus to local development (#239) * add prometheus & grafana to local dev * Add host/report metrics (per hour/minute/day/source/etc) (#244) * Add host metrics to Grafana * Add metric to capture kafka errors (#245) * Add metric to capture kafka errors * Add grafana charts and prometheus metrics to capture db errors (#246) * Change our base image from CentOS to UBI (#247) * Initial changes to test moving from a centos image to ubi * Stop processors when fatal errors occur (#252) * Initial changes for adding a shutdown for all processors when fatal errors occur * Added Jenkinsfile for e2e smoke tests (#255)
abaiken
added a commit
that referenced
this pull request
Oct 31, 2019
* Remove report archives from postgresDB after specified time (#233) * initial changes to add a garbage collector. * Scheduled monthly dependency update for September (#237) * Update requests-mock from 1.6.0 to 1.7.0 * Update requests-mock from 1.6.0 to 1.7.0 * Update sphinx from 2.1.2 to 2.2.0 * Update sphinx from 2.1.2 to 2.2.0 * Update lazy-object-proxy from 1.4.1 to 1.4.2 * Update port-for from 0.3.1 to 0.4 * Update virtualenv from 16.7.2 to 16.7.4 * Update zipp from 0.5.2 to 0.6.0 * Add Grafana & Prometheus to local development (#239) * add prometheus & grafana to local dev * Add host/report metrics (per hour/minute/day/source/etc) (#244) * Add host metrics to Grafana * Add metric to capture kafka errors (#245) * Add metric to capture kafka errors * Add grafana charts and prometheus metrics to capture db errors (#246) * Change our base image from CentOS to UBI (#247) * Initial changes to test moving from a centos image to ubi * Stop processors when fatal errors occur (#252) * Initial changes for adding a shutdown for all processors when fatal errors occur * Added Jenkinsfile for e2e smoke tests (#255) * Updated the services defined for the yupana smoke tests (#257) * Updated the services defined for the yupana smoke tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
DB ERROR HANDLING TESTS:
docker stop yupana_db_1docker start yupana_db_1and restart the server -and watch it process the first report immediately - as well as pull the second one off the queuedocker start yupana_db_1
KAFKA ERROR HANDLING TESTS:
docker stop docker_kafka_1before the server starts and watch it shutoff processors( This will take a while but it will eventually stop due to a kafka timeout error and trigger the processors to shut down)
The Kafka LOG errors are a bug with aiokafka --> see aio-libs/aiokafka#496)