Updates to Sources/Scans UI views #470
Conversation
There was a problem hiding this comment.
Going ahead and approving, found a fix for unit test, if you're curious...
facebook/create-react-app#3482 (comment)
Once this stuff is in, I'll go ahead and make the noted mod.
| </Router> | ||
| </Provider>, | ||
| div | ||
| ); |
There was a problem hiding this comment.
This took a bit of search... so part of the issue with these components is we have an async aspect, hence one of the problems with Fetch (not the non-existent finally method). Adding this React.unmountComponentAtNode(div) after line 19 ensures the initial mount and immediate unmount of the component for a quick test, soooo like so:
ReactDOM.render(
<Provider store={store}>
<Router>
<App />
</Router>
</Provider>,
div
);
ReactDOM.unmountComponentAtNode(div);If we combine this with converting the finally to a then or simply removing them. The tests should all pass with just a general console warning about the redirect... which we can address later.
Found this here... facebook/create-react-app#3482 (comment)
| message: 'Adding sources is not yet implemented' | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Good first round!
Probably a concept we have to evolve since it's hard to visualize, combining these dispatches into grouped actions ... so in the end, maybe something like
runScans() {
Store.dispatch({
type: scansTypes.DO_ALL_THINGS_FOR_RUN_SCANS,
...
updates #434