Add recovery stats as part of ConnectionStats #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like |
Ralith
previously approved these changes
Jan 9, 2021
Seems good to me too for the current values. We can have something else for values which are persistent between paths too. More fields don't have more cost. |
This is an alternative version of quinn-rs#972, where we add the new stats to ConnectionStats instead of exposing additional accessors. The naming of `recovery` could probably be improved. `path` might be an option. But where would we add something like packet loss? That seems more like an overall stat.
Ralith
approved these changes
Jan 10, 2021
djc
approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative version of #972, where we add the new stats
to ConnectionStats instead of exposing additional accessors.
The naming of
recoverycould probably be improved.pathmightbe an option. But where would we add something like packet loss?
That seems more like an overall stat.