Return UnknownStream from Connection::reset for closed/reset streams #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 71.33% 70.89% -0.45%
==========================================
Files 73 74 +1
Lines 13111 12999 -112
==========================================
- Hits 9353 9215 -138
- Misses 3758 3784 +26
Continue to review full report at Codecov.
|
Ralith
force-pushed
the
reset-cleanup
branch
2 times, most recently
from
fbdc68c to
c9b0b7f
Compare
|
@stammw just to be sure: note that your review is requested here, as well. :) |
Improves consistency with other stream interfaces. H3 logic was updated to ignore errors to preserve existing behavior, but future work might want to insert some unwraps there if static correctness guarantees are available.
|
Resolved merge conflict, just need a quick sanity-check for the h3 changes. |
djc
approved these changes
May 23, 2020
stammw
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves consistency with other stream interfaces. H3 logic was
updated to ignore errors to preserve existing behavior, but future
work might want to insert some unwraps there if static correctness
guarantees are available.