Refactor receive stream buffering #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 71.33% 71.55% +0.21%
==========================================
Files 73 74 +1
Lines 13111 13277 +166
==========================================
+ Hits 9353 9500 +147
- Misses 3758 3777 +19
Continue to review full report at Codecov.
|
djc
reviewed
May 12, 2020
|
(Also very well-factored commits here. In terms of preventing unnecessary rebase efforts, maybe submit the first four commits separately so we can merge them immediately?) |
Merged
|
Cherry-picked the simple stuff into #770. |
Ralith
force-pushed
the
buffer-bounds
branch
2 times, most recently
from
d993bd9 to
cde86cb
Compare
|
Rebased. |
Ralith
force-pushed
the
buffer-bounds
branch
2 times, most recently
from
2389fbf to
f4d5058
Compare
|
Got rid of a bunch of unnecessary complexity regarding |
Ralith
force-pushed
the
buffer-bounds
branch
2 times, most recently
from
421a94e to
a08e058
Compare
djc
reviewed
May 25, 2020
When there's a leading gap in the buffered data or unordered reads are in use, `self.offset` does not represent the starting point of the first chunk.
DataRecvd was used to identify when all data has been received but not yet read by the application, but we can determine that on-demand in the Recvd state.
Ensures we don't yield the same data to the application repeatedly, and only issue flow control credit in response to new data.
This was probably unreachable as we dispose of closed receive streams immediately after they become such, but if that ever changes we still don't want to panic.
|
Nice work. |
djc
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #735. Should marginally improve performance for ordered reads due to isolation of the (now somewhat more) complex
RangeSetoperations to the unordered case where they're necessary, leaving simple cursor-based logic for ordered behavior.