Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lack of reexport of ConnectionStats and ResetError #1920

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

TirushOne
Copy link
Contributor

@TirushOne TirushOne commented Jul 17, 2024

ConnectionStats and ResetError are now reexported for use with the public interface, they weren't before.

Respecfully, please take better care of your libeary. I encountered these issues and thought I had something wrong because surley something as obvious as not reexporting your own types would have been cought and fixed before publishing the latest release of quinn, but I guess not. But regaurdless, there it is, it's fixed.

fix rexport of ConnectionStats and ResetError
@TirushOne TirushOne changed the title Fix lack of rexport of ConnectionStats and ResetError Fix lack of reexport of ConnectionStats and ResetError Jul 17, 2024
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Respecfully, please take better care of your libeary. I encountered these issues and thought I had something wrong because surley something as obvious as not reexporting your own types would have been cought and fixed before publishing the latest release of quinn, but I guess not.

Unfortunately this kind of issue (due to the difference between being "visible" and "nameable") is quite often not all that obvious, I've seen similar issues in several different projects.

FWIW, feedback like "take better care of your library" isn't very constructive, I suggest finding a different way of giving feedback.

@djc djc merged commit 411abe9 into quinn-rs:main Jul 17, 2024
8 checks passed
@TirushOne
Copy link
Contributor Author

TirushOne commented Jul 24, 2024

FWIW, feedback like "take better care of your library" isn't very constructive, I suggest finding a different way of giving feedback.

Well I did make this pr in a fit of frustration and I the feed back isn't the most contructive lol. So I will try to be a bit more contructive next time I have a bug fix.
Also will this change be coming out in a bug fix patach soon? Or will it be coming with the next scheduled update? I have a project using quinn atm and having this fix available soon would be very conviniant.

@djc
Copy link
Member

djc commented Jul 24, 2024

Also will this change be coming out in a bug fix patach soon? Or will it be coming with the next scheduled update? I have a project using quinn atm and having this fix available soon would be very conviniant.

There is no schedule for updates, but we plan to push out some maintenance releases soon. Want to get some in-flight PRs merged before we do so, but I think it should happen soon (probably this week).

@TirushOne
Copy link
Contributor Author

There is no schedule for updates, but we plan to push out some maintenance releases soon. Want to get some in-flight PRs merged before we do so, but I think it should happen soon (probably this week).
Good to hear

flub pushed a commit to n0-computer/quinn that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants