We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While working on #1000, I realized that we are not deduplicating already inserted duplicates when entering unordered mode:
quinn/quinn-proto/src/connection/assembler.rs
Lines 32 to 38 in 2a8c93b
#[test] fn read_unordered() { let mut x = Assembler::new(); x.insert(0, Bytes::from_static(b"abc"), 3); x.insert(0, Bytes::from_static(b"abc"), 3); x.ensure_ordering(false).unwrap(); assert_eq!( x.read(3, false), Some(Chunk::new(0, Bytes::from_static(b"abc"))) ); assert_eq!(x.read(3, false), None); }
Is this intentional?
The text was updated successfully, but these errors were encountered:
quinn-proto: deduplicate when entering unordered mode (fix quinn-rs#1009
2b3c67a
)
dccecd8
27363a6
2687ef8
No branches or pull requests
While working on #1000, I realized that we are not deduplicating already inserted duplicates when entering unordered mode:
quinn/quinn-proto/src/connection/assembler.rs
Lines 32 to 38 in 2a8c93b
With that behavior, the following test will fail:
Is this intentional?
The text was updated successfully, but these errors were encountered: