Fix doc URLs in catalog #4205
Draft
Fix doc URLs in catalog #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like URLs were changed by c5edede. There are redirects to new locations but URL fragment is not preserved after redirect. This change is mostly to fix URLs with fragments, others are updated for uniformity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4205 +/- ##
=======================================
Coverage 37.69% 37.69%
=======================================
Files 768 768
Lines 35317 35317
Branches 5215 5215
=======================================
Hits 13313 13313
Misses 20769 20769
Partials 1235 1235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sir-sigurd
commented
Oct 30, 2024
| @@ -167,7 +167,7 @@ const defaultHandlers: ErrorHandler[] = [ | |||
| <br /> | |||
| <StyledLink | |||
| target="_blank" | |||
| href={`${docs}/walkthrough/working-with-the-catalog#access-control`} | |||
| href={`${docs}/quilt-platform-administrator/admin#users-and-roles`} | |||
There was a problem hiding this comment.
this anchor was broken in 2c1aec8#diff-c83d883e5d164b4035b039bb964282da0e39d8bafa72e2b193cd6760d8b976b1
I'm not sure if it should refer to the old place: https://docs.quiltdata.com/quilt-platform-catalog-user/working-with-the-catalog#admin-ui
|
Ouch, sorry about that. Fixes approved. |
drernie
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like URLs were changed by c5edede. There are redirects to new locations but URL fragment is not preserved after redirect.
This change is mostly to fix URLs with fragments, others are updated for uniformity.