Remove excessive citation of importance level section #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the importance level is _that important_ that we need a deep link into the qlog main schema every time. Its a visual distraction. So instead, highlight the convention in the convention section and remove all these redundant links.
|
Yes, this was annoying me as well! One questions is if you intentionally not removed this from the events in the main schema as well (e.g., https://quicwg.org/qlog/draft-ietf-quic-qlog-main-schema#section-9.1)? I can see an argument for keeping them intact in that doc but not in the others, but if it wasn't intentional, maybe remove them there as well. Otherwise LGTM! |
rmarx
approved these changes
Mar 13, 2025
|
Leaving them in main schema was an accident, I'll fix that up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the importance level is that important that we need
a deep link into the qlog main schema every time. Its a visual
distraction. So instead, highlight the convention in the convention
section and remove all these redundant links.