Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Initial salt, Retry keys, and samples for -29 #3711

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Update Initial salt, Retry keys, and samples for -29 #3711

merged 3 commits into from
Jun 9, 2020

Conversation

martinthomson
Copy link
Member

No description provided.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -tls labels Jun 2, 2020
@DavidSchinazi
Copy link
Contributor

Any chance we could also update the initial salt?

@martinthomson
Copy link
Member Author

I was saving that for the final version, by popular demand. If you have a reason to change, then I can do that (I'll also want to update the keys for Retry in that case).

@rpaulo
Copy link
Contributor

rpaulo commented Jun 3, 2020

I agree with @martinthomson. Let's leave the salt update to the final version.

@DavidSchinazi
Copy link
Contributor

With Google's QUIC deployment, we're already experiencing version ossification due to middleboxes inspecting initial packets - some of our traffic is stuck on older versions of GoogleQUIC because of this. Changing the salts every time we change the version number will help remind everyone that this is not an ossified aspect of the protocol. The cost to implementors is pretty much zero.

@rpaulo out of curiosity, why the pushback?

@marten-seemann
Copy link
Contributor

What @DavidSchinazi says makes sense to me, so I would be in favor of shipping draft-29 with new salts.

@martinthomson martinthomson changed the title Update samples for -29 Update Initial salt, Retry keys, and samples for -29 Jun 4, 2020
@marten-seemann marten-seemann mentioned this pull request Jun 5, 2020
Merged
@marten-seemann
Copy link
Contributor

I updated the salts and the test vectors in quic-go, and I can confirm that the values match.

@martinthomson martinthomson merged commit 6563329 into master Jun 9, 2020
@martinthomson martinthomson deleted the samples-29 branch June 9, 2020 22:31
alagoutte added a commit to alagoutte/base-drafts that referenced this pull request Jun 10, 2020
@alagoutte
Update Initial salt, Retry keys, and samples (quicwg#3711) to changelog
faab2c4
martinthomson added a commit that referenced this pull request Jun 16, 2020
@martinthomson
Merge pull request #3752 from alagoutte/changelog_draft29_update_init…
259948e 
…ial_salt

 Update Initial salt, Retry keys, and samples (#3711) to changelog
@LPardue LPardue mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

@DavidSchinazi DavidSchinazi DavidSchinazi approved these changes

@janaiyengar janaiyengar janaiyengar approved these changes

Assignees
No one assigned
Labels
-tls editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinthomson @DavidSchinazi @rpaulo @marten-seemann @janaiyengar