Make facet indexation and storage optional #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpouget
force-pushed
the
facet-optional-storage-and-index
branch
2 times, most recently
from
f413fb6 to
5df8166
Compare
fmassot
reviewed
Mar 23, 2021
The goal here was to be able to ensure presence of the doc in the store even if it's not indexed (and by extension check it's not indexed). But maybe it's not the best place to do this. |
lpouget
force-pushed
the
facet-optional-storage-and-index
branch
2 times, most recently
from
3afaf86 to
2b0d218
Compare
Added a FacetOptions for HierarchicalFacet which add indexed and stored flags to it. Propagate change and update tests accordingly Added a test to ensure that a not indexed flag was taken care of. Added on Value implem the `path()` function to return the stored facet.
lpouget
force-pushed
the
facet-optional-storage-and-index
branch
from
2b0d218 to
4b34231
Compare
fmassot
reviewed
Mar 24, 2021
There was a problem hiding this comment.
@fulmicoton I'm ok with the PR. I'm just a little bit annoyed by the verbosity of tests but it's probably better to handle that in another issue.
| @@ -108,19 +108,22 @@ impl SegmentReader { | |||
| /// Accessor to the `FacetReader` associated to a given `Field`. | |||
| pub fn facet_reader(&self, field: Field) -> crate::Result<FacetReader> { | |||
| let field_entry = self.schema.get_field_entry(field); | |||
| if field_entry.field_type() != &FieldType::HierarchicalFacet { | |||
| return Err(crate::TantivyError::InvalidArgument(format!( | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
FacetOptionsforHierarchicalFacetwhich add indexed and stored flags to it.Propagate change and update tests accordingly
Added a test to ensure that a not indexed flag was taken care of.
Added on
Valueimplementation thepath()function to return the stored facet.Fixes #986