Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove index sorting #2434

Merged
merged 1 commit into from
Jun 13, 2024

remove index sorting

8a9fb0b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

remove index sorting #2434

remove index sorting
8a9fb0b
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jun 13, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 294 in src/indexer/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

warning: useless use of `format!`
   --> src/indexer/mod.rs:294:14
    |
294 |             (format!("{field_name_out_internal}"), Type::Str),
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `field_name_out_internal.to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default

Check warning on line 2215 in src/indexer/index_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
    --> src/indexer/index_writer.rs:2215:41
     |
2215 |         let ops: Vec<_> = (0..1000).map(|id| IndexingOp::add(id)).collect();
     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `IndexingOp::add`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
     = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 1580 in src/indexer/index_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/indexer/index_writer.rs:1580:41
     |
1580 |                     existing_ids.remove(&id);
     |                                         ^^^ help: change this to: `id`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 1576 in src/indexer/index_writer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
    --> src/indexer/index_writer.rs:1576:41
     |
1576 |                     existing_ids.remove(&id);
     |                                         ^^^ help: change this to: `id`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
     = note: `#[warn(clippy::needless_borrow)]` on by default