New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip field #1553

Merged

PSeitz merged 27 commits into main from ip_field

Oct 11, 2022

Contributor

PSeitz commented Sep 26, 2022

add u128 multivalue reader and writer
add ip to schema
add ip writers, handle merge

fulmicoton reviewed

View reviewed changes

src/fastfield/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/query/query_parser/query_parser.rs Outdated Show resolved Hide resolved

codecov-commenter commented Sep 26, 2022 •

edited

Loading

Codecov Report

Merging #1553 (b2ca83a) into main (5f565e7) will increase coverage by 0.06%.
The diff coverage is 90.18%.

@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   93.78%   93.85%   +0.06%     
==========================================
  Files         252      253       +1     
  Lines       46380    47074     +694     
==========================================
+ Hits        43499    44181     +682     
- Misses       2881     2893      +12

Impacted Files	Coverage Δ
fastfield_codecs/src/main.rs	`0.53% <0.00%> (-0.01%)`	⬇️
src/fastfield/mod.rs	`99.71% <ø> (ø)`
src/fastfield/multivalued/mod.rs	`98.45% <ø> (-0.78%)`	⬇️
src/indexer/segment_writer.rs	`96.23% <0.00%> (-0.18%)`	⬇️
src/postings/per_field_postings_writer.rs	`94.11% <ø> (ø)`
src/postings/postings_writer.rs	`97.66% <0.00%> (-0.58%)`	⬇️
src/query/query_parser/query_parser.rs	`94.67% <0.00%> (-0.34%)`	⬇️
src/schema/mod.rs	`100.00% <ø> (ø)`
src/schema/term.rs	`85.32% <0.00%> (-0.34%)`	⬇️
src/schema/field_type.rs	`74.14% <9.52%> (-4.11%)`	⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

PSeitz force-pushed the ip_field branch 4 times, most recently from 992b259 to 6834424 Compare

September 27, 2022 02:24

fulmicoton reviewed

View reviewed changes

src/schema/document.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/schema/document.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/schema/field_entry.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/postings/per_field_postings_writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/indexer/merger.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/indexer/merger.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/writer.rs Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/writer.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/writer.rs Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/reader.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

src/fastfield/multivalued/reader.rs Outdated Show resolved Hide resolved

PSeitz force-pushed the ip_field branch 3 times, most recently from 5862f78 to eb00ef6 Compare

September 30, 2022 03:12

fulmicoton reviewed

View reviewed changes

fastfield_codecs/benches/bench.rs Outdated Show resolved Hide resolved

PSeitz requested a review from fulmicoton

September 30, 2022 08:31

fulmicoton reviewed

View reviewed changes

fastfield_codecs/src/column.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

fastfield_codecs/src/column.rs Outdated Show resolved Hide resolved

fulmicoton reviewed

View reviewed changes

fastfield_codecs/src/column.rs Outdated Show resolved Hide resolved

PSeitz and others added 23 commits

October 7, 2022 16:25


          remove comment

6113e04


          use iter api

c8713a0


          fix get_between_vals forwarding

5a76e6c

fix get_between_vals forwarding in monotonicmapping column by adding an additional conversion function Output->Input


          rename to IpAddr

309449d


          remove null handling

087beaf


          rename to iter_gen

eeb1f19


          remove roaring

f5039f1


          expect instead of unwrap

787a37b


          rename to iter_gen

67f453b


          group montonic mapping and inverse

cdc8e3a

fix mapping inverse
remove ip indexing
add get_between_vals test


          finalize ip addr rename

4d29ff4


          mark null handling TODO

5d6602a


          rename ip addr, use buffer

0b86658


          remove u128 type

e50e74a


          serialize ip as u128, add test for positions_to_docid

5171ff6


          use serializer for u128

2864bf7


          add StrictlyMonotonicFn

226a493


          enable test

a8a36b6


          improve comment

39f4e58


          add test

9a1609d


          use idx part only for positions_to_docid

96315df


          Apply suggestions from code review

f465173

Co-authored-by: Paul Masurel <paul@quickwit.io>


          use ipv6

534b1d3

Co-authored-by: Paul Masurel <paul@quickwit.io>

PSeitz force-pushed the ip_field branch from a843ffc to 534b1d3 Compare

October 7, 2022 08:56

PSeitz added 3 commits

October 7, 2022 16:56

fmt

b9b9135


          switch to ipv6, add monotonic_mapping tests

b2ca83a


          handle IpV4 serialization case

5c9cbee

fulmicoton approved these changes

View reviewed changes

PSeitz merged commit 3650d1f into main

PSeitz deleted the ip_field branch

October 11, 2022 05:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet