FileHandle: Change from boxed to Arc. #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing from a Box<dyn FileHandle> to an Arc<dyn FileHandle> would allow for a user of tantivy to manage file handles outside of tantivy and be able to manage their life cycle.
fulmicoton
approved these changes
Jul 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 94.22% 94.21% -0.02%
==========================================
Files 236 236
Lines 43778 43770 -8
==========================================
- Hits 41250 41238 -12
- Misses 2528 2532 +4
Continue to review full report at Codecov.
|
|
@pier-oliviert Your formatting settings seems incorrect.
|
pier-oliviert
force-pushed
the
file-handle-arc-argument
branch
from
1bd507a to
6ab249e
Compare
|
@fulmicoton just force-pushed what I hope is the final fix for the linter. Let me know if you need anything else from me. |
This was referenced Jan 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from a Box to an Arc would
allow for a user of tantivy to manage file handles outside of tantivy
and be able to manage their life cycle.
I'm currently working with tantivy and one of the thing I wanted to do was to manage file access outside of tantivy in a way that file access is abstracted completely from tantivy. I got everything working on my end, but I needed to make this change to tantivy because I needed shared ownership of a given FileHandle.
I believe this change is safe to other user of tantivy, but I am new to both Tantivy & Rust, so maybe there's something else that needs to change to make this happen.