-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collector + directory doc fixes #1247
Conversation
@@ -43,7 +43,6 @@ impl RetryPolicy { | |||
} | |||
|
|||
/// The `DirectoryLock` is an object that represents a file lock. | |||
/// See [`LockType`](struct.LockType.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DirectoryLockGuard
? It's private though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clue what it was
Codecov Report
@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 94.10% 94.19% +0.09%
==========================================
Files 205 206 +1
Lines 34457 34962 +505
==========================================
+ Hits 32426 32933 +507
+ Misses 2031 2029 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @saroh
Do you know if there is a command to check for broken links in the rustdoc?
thtat would be cool to add that to the CI
@fulmicoton seems supported https://doc.rust-lang.org/rustdoc/lints.html I'll give it a go for the future packages :) |
saroh@6ef8e20 should make |
Just fixing a few links :)
#1232