-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add none
compression
#1208
Add none
compression
#1208
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 94.06% 94.06%
=======================================
Files 205 205
Lines 34504 34514 +10
=======================================
+ Hits 32457 32467 +10
Misses 2047 2047
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the minor comments
When would someone want not any compressor? |
Removing dependencies. @shikhar only uses fast field, probably like a foreign key. I encounterred the same need in the past when working on a small index and web assembly. |
If none of the
{lz4,brotli,snappy}-compression
feature flags are present,Compressor::None
is used.It just copies the input slice to destination vector. The copy may be avoidable with some
Compressor
API changes, but left to a future optimization if it's even worthwhile - someone exercising the docstore will probably enable compression.